-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): remember pagination option, project search selection jumps into project #2821
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
280de36
to
3459279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes that needs to be in place before merging. Thanks for the PR!
a8a9628
to
4dacb86
Compare
Updated the pr with the changes requested @Marvin9 |
47c4424
to
f45a507
Compare
There is just one bug indirectly blocking this PR that I am looking at ie. in local storage change the page size to the page which does not exist and refresh project list page |
@Marvin9 maybe use useEffect to check if data is available? else reset it. just an idea so when you set the page number on ur storage to higher than the number of pages, it goes back to first, want me to add it to this PR? ( tested it locally and works ) |
@sergiofteixeira yes please push that change. I tested in local and it resolves the issue that I mentioned |
Also don't forget to run |
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
…ger fix Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
6ef1193
to
e914357
Compare
@Marvin9 pushed those changes and ran lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change and then we can merge after CI checks. Thanks!
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
pushed the change @Marvin9 |
Signed-off-by: Sergio Teixeira <sergio@triggerise.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2821 +/- ##
==========================================
+ Coverage 48.82% 50.01% +1.18%
==========================================
Files 270 274 +4
Lines 23941 24386 +445
==========================================
+ Hits 11690 12197 +507
+ Misses 11620 11539 -81
- Partials 631 650 +19 ☔ View full report in Codecov by Sentry. |
Hello, my first contribution.
This adds browser local storage to remember pagination option.
Also improves the search to show only what you searched for and when selection a project you jump into it.