Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): perform token validity check #2866

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Oct 28, 2024

fixes #2793

Thanks @krancour for help. We couldn't exactly find the reason but token validity check would fix it.

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from a team as a code owner October 28, 2024 22:21
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 343a78a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/672120638983e00008cc7c84
😎 Deploy Preview https://deploy-preview-2866.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.09%. Comparing base (f31831b) to head (343a78a).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
+ Coverage   48.97%   50.09%   +1.11%     
==========================================
  Files         270      275       +5     
  Lines       23898    24427     +529     
==========================================
+ Hits        11705    12236     +531     
+ Misses      11562    11521      -41     
- Partials      631      670      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour
Copy link
Member

When we talked this through yesterday, I thought we had concluded that a new endpoint wasn't necessary. i.e. I thought that 401s from existing API calls just needed to be handled with a redirect to the login page.

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@rpelczar rpelczar self-assigned this Oct 29, 2024
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9
Copy link
Contributor Author

Marvin9 commented Oct 29, 2024

Discussed with @krancour and we think its enough to handle API failure due to auth checks in UI itself. All the normal cases are handled beforehand by interceptor

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from rpelczar October 29, 2024 17:50
@Marvin9 Marvin9 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 5366f30 Oct 29, 2024
17 checks passed
@Marvin9 Marvin9 deleted the Marvin9/fix-unauth-redirect branch October 29, 2024 18:17
fykaa pushed a commit to fykaa/kargo that referenced this pull request Nov 4, 2024
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI does not redirect to login page
3 participants