-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): perform token validity check #2866
Conversation
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2866 +/- ##
==========================================
+ Coverage 48.97% 50.09% +1.11%
==========================================
Files 270 275 +5
Lines 23898 24427 +529
==========================================
+ Hits 11705 12236 +531
+ Misses 11562 11521 -41
- Partials 631 670 +39 ☔ View full report in Codecov by Sentry. |
When we talked this through yesterday, I thought we had concluded that a new endpoint wasn't necessary. i.e. I thought that 401s from existing API calls just needed to be handled with a redirect to the login page. |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Discussed with @krancour and we think its enough to handle API failure due to auth checks in UI itself. All the normal cases are handled beforehand by interceptor |
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
fixes #2793
Thanks @krancour for help. We couldn't exactly find the reason but token validity check would fix it.