Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Links/Buttons in the Pipeline are not working #2915

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

rpelczar
Copy link
Contributor

After merging this PR, all links/buttons stopped working, so we can not open Stage details or do promotions.

Signed-off-by: Rafal Pelczar <rafal@akuity.io>
@rpelczar rpelczar requested a review from a team as a code owner November 12, 2024 00:44
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for docs-kargo-io canceled.

Name Link
🔨 Latest commit 6bd4855
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6732a4ebf11957000885a338

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.92%. Comparing base (6c10f68) to head (6bd4855).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2915   +/-   ##
=======================================
  Coverage   49.92%   49.92%           
=======================================
  Files         275      275           
  Lines       24668    24668           
=======================================
  Hits        12315    12315           
  Misses      11676    11676           
  Partials      677      677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this to work.

@hiddeco
Copy link
Contributor

hiddeco commented Nov 12, 2024

Merging this, as getting main into a working state is an immediate priority.

@hiddeco hiddeco added this pull request to the merge queue Nov 12, 2024
Merged via the queue into akuity:main with commit c0d47e0 Nov 12, 2024
23 checks passed
@hiddeco hiddeco added this to the v1.1.0 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants