-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): add functions to EL for finding artifacts in promo's freight collection #2925
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
+ Coverage 49.97% 50.20% +0.22%
==========================================
Files 276 276
Lines 24811 24916 +105
==========================================
+ Hits 12400 12509 +109
+ Misses 11724 11718 -6
- Partials 687 689 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome, excellent job @krancour 🙇 🔥
Before:
After:
Cases not requiring origin disambiguation are even more straightforward:
Similar functions are defined for accessing images and charts from the Promo's Freight collection.
See doc updates for more usage details and examples.
1b80bf0 is the core of this PR.
Most other commits focus on a single promotion step each:
A large chunk of this PR is new tests on schemas that I touched.
Short term this makes schemas slightly more complex and introduces additional conditionals into step implementations, but once we're able to fully remove the more "magical" fields and the logic that supports them, the schemas and step implementations will both be simplified beyond the state they were in prior to this PR. i.e. We get to delete lots of stuff in 1.2.
This branch of my examples is updated to take full advantage of these improvements: https://github.com/krancour/kargo-examples/tree/for-v1.1.0