ci: add typechecks for UI #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
rpelczar
approved these changes
Nov 19, 2024
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Marvin9
force-pushed
the
Marvin9/typecheck-in-ci
branch
from
357f006 to
67afa8c
Compare
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2949 +/- ##
==========================================
- Coverage 50.92% 50.91% -0.01%
==========================================
Files 279 279
Lines 25180 25175 -5
==========================================
- Hits 12823 12818 -5
Misses 11666 11666
Partials 691 691 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
krancour
approved these changes
Nov 19, 2024
fykaa
pushed a commit
to fykaa/kargo
that referenced
this pull request
Dec 20, 2024
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR the UI type issues won't go unnoticed and would give more confidence on UI stability if any schema is changed from backend.