Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): use tini to reap zombie processes #2959

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Nov 18, 2024

Fixes #2926

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added kind/bug priority/high docker Pull requests that update Docker code backport/release-1.0 labels Nov 18, 2024
@hiddeco hiddeco added this to the v1.0.4 milestone Nov 18, 2024
@hiddeco hiddeco requested a review from a team as a code owner November 18, 2024 22:59
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit ad22089
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/673bcf9acbacc2000808b307
😎 Deploy Preview https://deploy-preview-2959.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.92%. Comparing base (2fa4fc4) to head (ad22089).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2959   +/-   ##
=======================================
  Coverage   50.92%   50.92%           
=======================================
  Files         279      279           
  Lines       25180    25180           
=======================================
  Hits        12823    12823           
  Misses      11666    11666           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added this pull request to the merge queue Nov 18, 2024
Merged via the queue into akuity:main with commit 34c6128 Nov 18, 2024
19 checks passed
@hiddeco hiddeco deleted the add-tini branch November 18, 2024 23:53
@akuitybot
Copy link

Backport failed for release-1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.0
git worktree add -d .worktree/backport-2959-to-release-1.0 origin/release-1.0
cd .worktree/backport-2959-to-release-1.0
git switch --create backport-2959-to-release-1.0
git cherry-pick -x 34c612821d126a3cb3f95ff6132cec0b248d988a

hiddeco added a commit to hiddeco/kargo that referenced this pull request Nov 19, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit 34c6128)
@hiddeco hiddeco self-assigned this Nov 19, 2024
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kargo-controller creates zombie [git] processes
3 participants