Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): 'http' and 'yaml-update' promotion directives support #2987

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Nov 23, 2024

fixes #2986

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 0aa360e
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/674156cb81c6bf00087b67c5
😎 Deploy Preview https://deploy-preview-2987.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Marvin9 Marvin9 added this to the v1.1.0 milestone Nov 23, 2024
@Marvin9 Marvin9 requested a review from krancour November 23, 2024 04:15
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (cc293f0) to head (0aa360e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2987   +/-   ##
=======================================
  Coverage   51.08%   51.08%           
=======================================
  Files         282      282           
  Lines       25365    25365           
=======================================
  Hits        12957    12957           
  Misses      11709    11709           
  Partials      699      699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@krancour
Copy link
Member

🔥 That was fast @Marvin9! Thank you!

@Marvin9 Marvin9 added this pull request to the merge queue Nov 23, 2024
Merged via the queue into main with commit 384c547 Nov 23, 2024
23 checks passed
@Marvin9 Marvin9 deleted the Marvin9/feat-new-directives-ui-support branch November 23, 2024 19:07
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
…ty#2987)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
…ty#2987)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: support for new steps yaml-update and http
2 participants