-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller)!: check create setting when attempting to clone non-existent remote branch #3012
Conversation
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3012 +/- ##
==========================================
- Coverage 51.10% 51.07% -0.04%
==========================================
Files 282 283 +1
Lines 25365 25382 +17
==========================================
Hits 12963 12963
- Misses 11704 11720 +16
- Partials 698 699 +1 ☔ View full report in Codecov by Sentry. |
Successfully created backport PR for |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.0
git worktree add -d .worktree/backport-3012-to-release-1.0 origin/release-1.0
cd .worktree/backport-3012-to-release-1.0
git switch --create backport-3012-to-release-1.0
git cherry-pick -x ad139d2d6e2b84644fde8596b89ff0952b4c049e |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.1
git worktree add -d .worktree/backport-3012-to-release-1.1 origin/release-1.1
cd .worktree/backport-3012-to-release-1.1
git switch --create backport-3012-to-release-1.1
git cherry-pick -x ad139d2d6e2b84644fde8596b89ff0952b4c049e |
…xistent remote branch (akuity#3012) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
…xistent remote branch (akuity#3012) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
The
git-clone
step'scheckout[].create
setting wasn't being checked before creating a new remote branch.Thanks to @34fathombelow for finding this.
This is a breaking change only insofar as it changes (incorrect) behavior.
If it trips anyone up, the error message should be informative enough for them to fix the issue quickly.