Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller)!: check create setting when attempting to clone non-existent remote branch #3012

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

krancour
Copy link
Member

The git-clone step's checkout[].create setting wasn't being checked before creating a new remote branch.

Thanks to @34fathombelow for finding this.

This is a breaking change only insofar as it changes (incorrect) behavior.

If it trips anyone up, the error message should be informative enough for them to fix the issue quickly.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4bb0ca3
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67476b21ea5aa500085b1fe4
😎 Deploy Preview https://deploy-preview-3012.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (ac18cc2) to head (4bb0ca3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/directives/git_cloner.go 9.09% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3012      +/-   ##
==========================================
- Coverage   51.10%   51.07%   -0.04%     
==========================================
  Files         282      283       +1     
  Lines       25365    25382      +17     
==========================================
  Hits        12963    12963              
- Misses      11704    11720      +16     
- Partials      698      699       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour added this pull request to the merge queue Nov 27, 2024
Merged via the queue into akuity:main with commit ad139d2 Nov 27, 2024
24 of 26 checks passed
@krancour krancour deleted the krancour/git-cloner-fix branch November 27, 2024 20:02
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
…xistent remote branch (#3012)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
(cherry picked from commit ad139d2)
@akuitybot
Copy link

@akuitybot
Copy link

Backport failed for release-1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.0
git worktree add -d .worktree/backport-3012-to-release-1.0 origin/release-1.0
cd .worktree/backport-3012-to-release-1.0
git switch --create backport-3012-to-release-1.0
git cherry-pick -x ad139d2d6e2b84644fde8596b89ff0952b4c049e

@akuitybot
Copy link

Backport failed for release-1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.1
git worktree add -d .worktree/backport-3012-to-release-1.1 origin/release-1.1
cd .worktree/backport-3012-to-release-1.1
git switch --create backport-3012-to-release-1.1
git cherry-pick -x ad139d2d6e2b84644fde8596b89ff0952b4c049e

fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
…xistent remote branch (akuity#3012)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
fykaa pushed a commit to fykaa/kargo that referenced this pull request Jan 16, 2025
…xistent remote branch (akuity#3012)

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants