Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Promotion on verification failure #3098

Merged

Conversation

hiddeco
Copy link
Contributor

@hiddeco hiddeco commented Dec 9, 2024

No description provided.

Signed-off-by: Hidde Beydals <hidde@hhh.computer>
@hiddeco hiddeco added this to the v1.1.1 milestone Dec 9, 2024
@hiddeco hiddeco self-assigned this Dec 9, 2024
@hiddeco hiddeco requested a review from a team as a code owner December 9, 2024 10:38
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 4f593fa
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6756c8adfcb6ef0008f062ed
😎 Deploy Preview https://deploy-preview-3098.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.21%. Comparing base (462e785) to head (4f593fa).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/stages/regular_stages.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3098   +/-   ##
=======================================
  Coverage   51.20%   51.21%           
=======================================
  Files         283      283           
  Lines       25466    25466           
=======================================
+ Hits        13041    13043    +2     
+ Misses      11729    11727    -2     
  Partials      696      696           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiddeco hiddeco added this pull request to the merge queue Dec 9, 2024
Merged via the queue into akuity:main with commit 2655a03 Dec 9, 2024
25 of 26 checks passed
@hiddeco hiddeco deleted the fix-allow-promo-on-verification-failure branch December 9, 2024 15:58
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
(cherry picked from commit 2655a03)
@akuitybot
Copy link

Successfully created backport PR for release-1.1:

fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants