Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): auto attach offline_access only if idp supports #3117

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix(auth): auto attach offline_access only if idp supports #3117

merged 2 commits into from
Dec 11, 2024

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Dec 10, 2024

fixes #3005

@Marvin9
fix(auth): auto attach only if idp supports
d2356fa 
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from a team as a code owner December 10, 2024 20:11
@Marvin9 Marvin9 self-assigned this Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit e56e05f
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6758a0d94700a100086198b8
😎 Deploy Preview https://deploy-preview-3117.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Marvin9 Marvin9 added this to the v1.1.2 milestone Dec 10, 2024
@Marvin9
chore: remove debug alert
e56e05f 
Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@Marvin9 Marvin9 requested a review from krancour December 10, 2024 20:13
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.26%. Comparing base (aecc74f) to head (e56e05f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   51.26%   51.26%           
=======================================
  Files         283      283           
  Lines       25563    25563           
=======================================
  Hits        13104    13104           
  Misses      11762    11762           
  Partials      697      697

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krancour
krancour approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@krancour krancour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Marvin9 Marvin9 added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 230f81b Dec 11, 2024
17 checks passed
@Marvin9 Marvin9 deleted the Marvin9/fix-oidc-issue branch December 11, 2024 14:37
diegocaspi pushed a commit to diegocaspi/kargo that referenced this pull request Dec 18, 2024
@Marvin9 @diegocaspi
fix(auth): auto attach offline_access only if idp supports (akuity#…
d5f698e 
…3117)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Signed-off-by: Diego Caspi <diegocaspi2002@gmail.com>
fykaa pushed a commit to fykaa/kargo that referenced this pull request Dec 20, 2024
@Marvin9 @fykaa
fix(auth): auto attach offline_access only if idp supports (akuity#…
8c389bb 
…3117)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krancour krancour krancour approved these changes

Assignees

@Marvin9 Marvin9

Labels
area/ui kind/bug priority/high
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

400 invalid scope for google oidc
2 participants
@Marvin9 @krancour