Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.2): fix: set region on default config for AWS creds #3494

Merged
merged 1 commit into from
Feb 14, 2025
Merged

chore(backport release-1.2): fix: set region on default config for AWS creds #3494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/credentials/kubernetes/ecr/managed_identity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
"or project-specific role is not authorized to obtain an ECR auth token. " +
"Falling back to using controller's IAM role directly.",
)
cfg.Region = region

Check warning on line 182 in internal/credentials/kubernetes/ecr/managed_identity.go

View check run for this annotation

Codecov / codecov/patch

internal/credentials/kubernetes/ecr/managed_identity.go#L182 

Added line #L182 was not covered by tests
ecrSvc = ecr.NewFromConfig(cfg)
output, err = ecrSvc.GetAuthorizationToken(ctx, &ecr.GetAuthorizationTokenInput{})
if err != nil {
Expand Down
Loading