-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: promote stages from freightline #736
Conversation
rbreeze
commented
Sep 13, 2023
Signed-off-by: Remington Breeze <remington@breeze.software>
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 46.56% 46.56%
=======================================
Files 97 97
Lines 6748 6748
=======================================
Hits 3142 3142
Misses 3451 3451
Partials 155 155 ☔ View full report in Codecov by Sentry. |
Issue 4: We lost the messaging about downstream subscribers affected by the promotion. I liked the level of detail that we previously provided when we clicked the PromoteSubscribers button, where we listed the Stages that would be affected by the promote. If we implement my suggestion in Issue 1, we should have enough space to present the same message we used to. |
Signed-off-by: Remington Breeze <remington@breeze.software>
@jessesuen I've updated to address your comments, with some tweaks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be good enough for now. LGTM!
Signed-off-by: Remington Breeze <remington@breeze.software>