feat(ui): more linkage #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
rpelczar
requested review from
alexmt,
devholic,
gdsoumya and
jessesuen
as code owners
Closed
5 tasks
rpelczar
requested review from
kencochrane,
krancour and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 46.81% 46.81%
=======================================
Files 97 97
Lines 6765 6765
=======================================
Hits 3167 3167
Misses 3446 3446
Partials 152 152 ☔ View full report in Codecov by Sentry. |
kencochrane
reviewed
Sep 14, 2023
jessesuen
reviewed
Sep 14, 2023
Comment on lines
70
to
76
| return shards.flatMap((shard) => { | ||
| return stage.spec?.promotionMechanisms?.argocdAppUpdates.map((argoCD) => ({ | ||
| label: argoCD.appName, | ||
| url: `${shard.url}/applications/${shard.namespace}/${argoCD.appName}` | ||
| })); | ||
| }); | ||
| }, [config, stage]); |
There was a problem hiding this comment.
When mapping ArgoCD apps to a shard, we can identify which shard it belongs to based on the following field in the Stage:
kind: Stage
metadata:
annotations:
kargo.akuity.io/shard: fooIn the normal case, the kargo.akuity.io/shard annotation might be missing entirely. Otherwise the value of the annotation should be one of the map keys in the GetConfig Argo CD URLs API
jessesuen
approved these changes
Sep 14, 2023
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-09-14.at.01.16.41.mov