enable API server to use TLS natively (without ingress) #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
requested review from
alexmt,
devholic,
gdsoumya,
jessesuen,
kencochrane and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 46.72% 46.59% -0.14%
==========================================
Files 97 97
Lines 6780 6799 +19
==========================================
Hits 3168 3168
- Misses 3460 3479 +19
Partials 152 152
☔ View full report in Codecov by Sentry. |
devholic
approved these changes
Sep 16, 2023
Co-authored-by: Sunghoon Kang <me@hoon.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #548
As noted in the issue, this covers cases where Ingress is not used or Ingress is used and company policy requires TLS end-to-end. (I guess those people should have service meshes, but you never know. 🤷 )
TLS with a self-signed cert is also enabled by default so users who ignore installation options still start off on more secure footing.