cli: add special table printer for stages #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
requested review from
alexmt,
devholic,
gdsoumya,
jessesuen,
kencochrane and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io canceled.
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
=======================================
Coverage 46.62% 46.62%
=======================================
Files 97 97
Lines 6797 6797
=======================================
Hits 3169 3169
Misses 3476 3476
Partials 152 152 ☔ View full report in Codecov by Sentry. |
rbreeze
approved these changes
Sep 19, 2023
| Rows: make([]metav1.TableRow, len(items)), | ||
| } | ||
| for i, item := range items { | ||
| // This func is only ever passed Stages |
There was a problem hiding this comment.
Is this enforced somehow? If not, should we duplicate this comment at the start of the function?
There was a problem hiding this comment.
Technically, nothing enforces it, but the function name should hopefully be a dead giveaway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
kargo get stages --project kargo-demo NAME AGE uat 121m test 122mAfter:
kargo get stages --project kargo-demo NAME CURRENT FREIGHT HEALTH AGE test b73f9d1afaca87254b64e64e5439557e86dcba79 Healthy 123m uat b73f9d1afaca87254b64e64e5439557e86dcba79 Healthy 121mWe need this if we're to have a CLI-centric quickstart. See #721
Long-term, idk about using this package for printing tables. It was nothing but pain.