rename image update strategies and remove image updater-related workarounds #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krancour
requested review from
alexmt,
devholic,
gdsoumya,
jessesuen,
kencochrane and
rbreeze
as code owners
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 46.41% 46.01% -0.41%
==========================================
Files 97 95 -2
Lines 6828 6742 -86
==========================================
- Hits 3169 3102 -67
+ Misses 3507 3491 -16
+ Partials 152 149 -3
☔ View full report in Codecov by Sentry. |
jessesuen
approved these changes
Sep 22, 2023
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
krancour
force-pushed
the
krancour/img-update-strategies
branch
from
475f659
to
326c48f
Compare
krancour
changed the title
jessesuen
approved these changes
Sep 25, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #817
cc @christianh814 I think this may clear up some confusion you encountered.