Relax image repo and git repo regexes

[moensch]

Fixes #846
Fixes #870

Note

I do have some code for a unit test ready-ish to validate this regex, but it does use go/ast and go/parser and is a bit .. involved. I pushed Copilot to its limits :)

Holler if you'd like me to add it.

Git regex validation

before

after

https://regex101.com/r/mjk9Ar/1

Docker repo regex validation

before

after

https://regex101.com/r/cnnffH/1

[netlify]

✅ Deploy Preview for docs-kargo-akuity-io canceled.

Name	Link
🔨 Latest commit	c5fa2d5
🔍 Latest deploy log	https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/651e3de3ce1e250008b55c00

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (533af4a) 46.04% compared to head (c5fa2d5) 46.04%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #915   +/-   ##
=======================================
  Coverage   46.04%   46.04%           
=======================================
  Files          95       95           
  Lines        6759     6759           
=======================================
  Hits         3112     3112           
  Misses       3497     3497           
  Partials      150      150           

Files	Coverage Δ
api/v1alpha1/stage_types.go	78.26% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[krancour]

@moensch this is stellar and extemely thorough. ❤️ Changes to regular expressions are sometimes very hard to review. I love how easy you made it to see the before and after results.

I did make some suggestions because if we're going to touch these particular expressions anyway, I think there are other outstanding things that need to be addressed.

I'd like to know what you think. I especially want to know if you feel the proposed alternatives do indeed retain the "relaxation" you were out to get, which I think can be summarized as allowing both - and . as separators in more places.

[krancour]

@moensch thanks so much!