Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refactoring of WarehouseSpec #986

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

krancour
Copy link
Member

@krancour krancour commented Oct 18, 2023

Fixes #954

Before:

apiVersion: kargo.akuity.io/v1alpha1
kind: Warehouse
metadata:
  name: my-warehouse
  namespace: kargo-demo
spec:
  subscriptions:
    images:
    - repoURL: krancour/nginx
      semverConstraint: ^1.24.0

After:

apiVersion: kargo.akuity.io/v1alpha1
kind: Warehouse
metadata:
  name: my-warehouse
  namespace: kargo-demo
spec:
  subscriptions:
  - image:
      repoURL: krancour/nginx
      semverConstraint: ^1.24.0

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for docs-kargo-akuity-io canceled.

Name Link
🔨 Latest commit 8ec263b
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/653119d47656d80008a724f1

@krancour krancour changed the title simplift subscriptions schema simplify subscriptions schema Oct 18, 2023
@krancour krancour changed the title simplify subscriptions schema minor refactoring of WarehouseSpec Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (8066ac0) 50.77% compared to head (8ec263b) 50.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   50.77%   50.85%   +0.07%     
==========================================
  Files         104      104              
  Lines        7573     7585      +12     
==========================================
+ Hits         3845     3857      +12     
+ Misses       3581     3580       -1     
- Partials      147      148       +1     
Files Coverage Δ
api/v1alpha1/warehouse_types.go 0.00% <ø> (ø)
internal/controller/warehouses/warehouses.go 63.47% <100.00%> (+4.17%) ⬆️
internal/controller/warehouses/git.go 72.83% <50.00%> (-1.52%) ⬇️
internal/controller/warehouses/helm.go 85.93% <60.00%> (-2.40%) ⬇️
internal/controller/warehouses/images.go 73.33% <50.00%> (-2.11%) ⬇️
internal/webhook/warehouse/webhook.go 91.81% <88.46%> (-2.36%) ⬇️
api/v1alpha1/zz_generated.deepcopy.go 10.10% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
Signed-off-by: Kent <kent.rancourt@gmail.com>
@krancour krancour force-pushed the krancour/subscription-cleanup branch from c3a6db9 to 8ec263b Compare October 19, 2023 11:58
@krancour krancour marked this pull request as ready for review October 19, 2023 14:13
@krancour krancour requested a review from a team as a code owner October 19, 2023 14:13
Copy link
Contributor

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krancour krancour merged commit 6940c01 into akuity:main Oct 19, 2023
@krancour krancour deleted the krancour/subscription-cleanup branch October 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minor refactoring of WarehouseSpec
2 participants