Fix review comments

akvelon · Jun 28, 2021 · 76c37fc · 76c37fc
1 parent cc5bd0d
commit 76c37fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
@@ -1106,6 +1106,11 @@ public void populateDisplayData(DisplayData.Builder builder) {
       super.populateDisplayData(builder);
       builder.add(DisplayData.item("rowMapper", getRowMapper().getClass().getName()));
       builder.add(DisplayData.item("coder", getCoder().getClass().getName()));
+      builder.add(DisplayData.item("partitionColumn", getPartitionColumn()));
+      builder.add(DisplayData.item("table", getTable()));
+      builder.add(DisplayData.item("numPartitions", getNumPartitions()));
+      builder.add(DisplayData.item("lowerBound", getLowerBound()));
+      builder.add(DisplayData.item("upperBound", getUpperBound()));
       if (getDataSourceProviderFn() instanceof HasDisplayData) {
         ((HasDisplayData) getDataSourceProviderFn()).populateDisplayData(builder);
       }

diff --git a/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcUtil.java b/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcUtil.java
@@ -271,6 +271,11 @@ public void processElement(ProcessContext c) {
       Integer lowerBound = params.get(0);
       Integer upperBound = params.get(1);
       Integer numPartitions = params.get(2);
+      if (lowerBound > upperBound) {
+        throw new RuntimeException(
+            String.format(
+                "Lower bound [%s] is higher than upper bound [%s]", lowerBound, upperBound));
+      }
       int stride = (upperBound - lowerBound) / numPartitions + 1;
       for (int i = lowerBound; i < upperBound - stride; i += stride) {
         String range = String.format("%s,%s", i, i + stride);