-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tour of Beam] [Frontend] Feedback #452
[Tour of Beam] [Frontend] Feedback #452
Conversation
playground/frontend/lib/pages/standalone_playground/widgets/playground_page_footer.dart
Outdated
Show resolved
Hide resolved
FeedbackRating? _rating; | ||
FeedbackRating? get rating => _rating; | ||
|
||
void setRating(FeedbackRating rating) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void setRating(FeedbackRating rating) { | |
set rating(FeedbackRating newValue) { |
?
onTapLink: (text, url, title) async { | ||
if (url != null) { | ||
await launchUrl(Uri.parse(url)); | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check how this works with internal links.
Also what URLs do we use in internal links? /tour/java/module/group/unit
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oleh said that we don't have internal links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (internal review).
Resolves apache#26075
Resolves apache#26115
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.