feat(select): options search #3091
Merged
+313
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibing
requested changes
Aug 3, 2022
| @@ -1,4 +1,5 @@ | |||
| <button | |||
| [hidden]="isOptionSearchInputAllowed" | |||
There was a problem hiding this comment.
Just simpler. Nebular subscribes to some button events like focus. And with *ngIf we should implement unsubscription and resubscription mechanisms. Looks too complicated for now
| @@ -849,7 +862,7 @@ export class NbSelectComponent | |||
| return this.selectionModel.map((option: NbOptionComponent) => option.content).join(', '); | |||
| } | |||
|
|
|||
| return this.selectionModel[0].content; | |||
| return this.selectionModel[0]?.content; | |||
There was a problem hiding this comment.
Earlier selectionView variable was used in the button only when something was selected. Now it is used in optionSearchInput all the time
| @@ -927,6 +950,10 @@ export class NbSelectComponent | |||
| if (this.isOpen) { | |||
| this.ref.detach(); | |||
| this.cd.markForCheck(); | |||
| this.selectClose.emit(); | |||
|
|
|||
| this.optionSearchInput.nativeElement.value = this.selectionView; | |||
There was a problem hiding this comment.
why don't we use FormControl for optionSearchInput?
There was a problem hiding this comment.
FormControl adds some complexity to updating search input value when something in select is updated. Probably should be improved, but for now, I think it's not bad.
|
Also, let's add tests |
Tibing
approved these changes
Aug 4, 2022
Tibing
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves: