-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issues #1782 & #1767 #1790
Open
psegalen
wants to merge
5
commits into
akveo:master
Choose a base branch
from
psegalen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2023
raqso
suggested changes
Dec 5, 2023
src/components/devsupport/components/measure/measure.component.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: raqso <raqsasg@gmail.com>
raqso
approved these changes
Dec 7, 2023
Hi. Is there a release, or planned release soon to fix the measureInWindow issue please |
michalq
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Issue #1767 is about modal flickering, it is caused by assigning decimal dimensions on modals, the fix just adds a Math.round() to width and height for Frames.
Issue #1782 is about a crash happening only on iOS when UI Kitten tries to measure a node that RN did not find, Android seems to support it but it makes an iOS app crash.