Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issues #1782 & #1767 #1790

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix for issues #1782 & #1767 #1790

wants to merge 5 commits into from

Conversation

psegalen
Copy link

@psegalen psegalen commented Nov 7, 2023

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Issue #1767 is about modal flickering, it is caused by assigning decimal dimensions on modals, the fix just adds a Math.round() to width and height for Frames.

Issue #1782 is about a crash happening only on iOS when UI Kitten tries to measure a node that RN did not find, Android seems to support it but it makes an iOS app crash.

@psegalen
Copy link
Author

psegalen commented Nov 7, 2023

I think it fixes #1751 so it may be taken for a duplicate of #1752 but it fixes 2 issues in one PR

….tsx

Co-authored-by: raqso <raqsasg@gmail.com>
@robpearmain
Copy link

Hi. Is there a release, or planned release soon to fix the measureInWindow issue please

facebook/react-native#41730

@rklomp rklomp mentioned this pull request Feb 6, 2024
@rklomp
Copy link

rklomp commented Feb 6, 2024

@psegalen See my comment at #1767 and #1802

I had to use Math.floor() to fix my issue instead of Math.round().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants