Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Remove asyncGenerator from babel-helpers #21

Closed
wants to merge 1 commit into from
Closed

Conversation

razh
Copy link

@razh razh commented Nov 8, 2017

asyncGenerator currently cannot be removed by rollup's tree-shaking
from rollup so it has to be done manually.

See rollup/rollup-plugin-babel#100 (comment)

Examples of this same config option:

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint: 4.9.0.
ESLint couldn't find the plugin "eslint-plugin-vue". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-vue is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-vue@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

@razh
Copy link
Author

razh commented Nov 8, 2017

This is no longer necessary. rollup 0.51 will remove this by default: https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0510

@razh razh closed this Nov 8, 2017
@akxcv
Copy link
Owner

akxcv commented Nov 9, 2017

Thanks! I'll take a look at this when I have the time.

@akxcv akxcv mentioned this pull request Nov 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants