Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port tests from tempdir to tempfile #35

Merged
merged 1 commit into from
Jan 21, 2025
Merged

port tests from tempdir to tempfile #35

merged 1 commit into from
Jan 21, 2025

Conversation

decathorpe
Copy link

The tempdir crate is unmaintained, was last updated seven years ago, and pulls in really old versions of some of its dependencies.

The tempfile crate is actively maintained and replacing code usages is straightforward.

@decathorpe
Copy link
Author

Whoops, looks like I didn't find all places where tempdir is used. Will push a fix.

The tempdir crate is unmaintained, was last updated seven years ago,
and pulls in really old versions of some of its dependencies.

The tempfile crate is actively maintained and replacing code usages
is straightforward.
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (6bd7086) to head (1bd8fc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   84.57%   86.41%   +1.83%     
==========================================
  Files           7        7              
  Lines         389      390       +1     
==========================================
+ Hits          329      337       +8     
+ Misses         60       53       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@al8n
Copy link
Owner

al8n commented Jan 21, 2025

Thanks!

@al8n al8n merged commit 0be8a38 into al8n:main Jan 21, 2025
10 checks passed
@decathorpe
Copy link
Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants