feat(metabase): allow full question id #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibclz
force-pushed
the
09-12-feat_metabase_allow_full_question_id
branch
from
eb51422
to
959c694
Compare
thibclz
changed the base branch from
main
to
09-12-feat_metabase_handle_query_errors
thibclz
force-pushed
the
09-12-feat_metabase_allow_full_question_id
branch
from
959c694
to
49d1e41
Compare
thibclz
force-pushed
the
09-12-feat_metabase_allow_full_question_id
branch
from
49d1e41
to
034b2d8
Compare
thibclz
changed the base branch from
thibaut-caillierez/feat-metabase-handle-query-errors
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Metabase only allowed question ids with the form
[0-9]+but what users instinctively use is often the "full id" of the question[0-9]+[A-Za-z-]-> now both are accepted.Fixes # (issue)