Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IceNet Notebook #6

Merged
merged 11 commits into from
Jun 16, 2022
Merged

Add IceNet Notebook #6

merged 11 commits into from
Jun 16, 2022

Conversation

acocac
Copy link
Member

@acocac acocac commented Oct 26, 2021

The notebook demonstrates IceNet using sample data of climate simulations and observational data fetched from a Zenodo repository.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@acocac acocac marked this pull request as draft October 28, 2021 09:40
@acocac acocac marked this pull request as ready for review October 28, 2021 14:05
@acocac
Copy link
Member Author

acocac commented Oct 28, 2021

@nbarlowATI the notebook is ready for revision. Thanks for helping me to sort out the issue with the conda environment!

@acocac acocac requested a review from nbarlowATI October 28, 2021 14:06
@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ground thruth" => "ground truth"


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path will depend on where the notebook is being run - I guess it makes sense to leave the one here as the one that works on the AzureML VM, but maybe could add a note to the text to point that out?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a the following text:

Note the python route after the exclamation in the line below works on the AzureML VM. The route might change in your local system.

How does it sound?

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"same input data of Nature Communications' paper " => "same input data as in the Nature Communications paper "


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"data as the forecast predictions" => "data, such as the forecast predictions"


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I missed it, but is there an explanation somewhere of where the ground truth SIC data comes from?


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding the following text to the Download ground truth SIC section explaining further details of the the ground truth SIC data.

We additionally download analysis-ready ground truth SIC data from a zenodo repository.

:::{note}
The analysis-ready ground truth SIC data were generated by running the script python3 icenet/download_sic_data.py in step **2) Download data** according to the [icenet-paper repository](https://github.com/tom-andersson/icenet-paper). The script downloads and concatenate [OSI-SAF SIC data](https://osisaf-hl.met.no/v2p1-sea-ice-index), OSI-450 (1979-2015) and OSI-430-b (2016-ownards), and saves it as monthly averages in a netCDF file.
:::

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"use a sample data" => "use a small sample of the data"


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! This interactive plot is great!!


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Tom and I tried one with hvplot but it wasn't giving the most aesthetic results. We ended using panels which is a great python library for generating dashboard and support Matplotlib plots.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nick!

@@ -0,0 +1,1411 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this plot, and the next one, when I ran them, the axis labels were cut off a little bit.


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which browser have you used? I remember the axis labels issue in Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants