Address Vite warnings in build step

[Zac-Evans]

I noticed that Vite shows a few warning messages when running the build step. These few changes clear those messages and should also improve chunking via rollup.

---

- Error
(!) bulletproof-react/apps/react-vite/src/app/routes/app/users.tsx is dynamically imported by bulletproof-react/apps/react-vite/src/app/routes/index.tsx but also statically imported by bulletproof-react/apps/react-vite/src/app/routes/index.tsx, dynamic import will not move module into another chunk.

- Solution
The loaders for discussions and users need to be in a separate file. Since the page components are being dynamically imported in the router, the static imports for the loaders generate this warning which ends up creating larger chunks sizes.

---

- Error
src/components/ui/dialog/dialog.tsx (1:0): Error when using sourcemap for reporting an error: Can't resolve original location of error.

- Solution
Remove "use client" from the dialog component.

---

- Error
Module "fs/promises" has been externalized for browser compatibility, imported by "bulletproof-react/apps/react-vite/src/testing/mocks/db.ts". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

- Solution
This isn't really an issue other than the error message, but you can prevent it by externalizing fs/promises via rollupOptions in the vite config

---

- Error
Some chunks are larger than 500 kB after minification. Consider: Using dynamic import() to code-split the application, Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks, Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.

- Solution
Fixing the dynamic/static import loader issue gets the chunk size down a bit.

Before	After

---

@alan2207 Thanks again for the great project, it has been really helpful for improving my project structures!

[netlify]

✅ Deploy Preview for bulletproof-react-app ready!

Name	Link
🔨 Latest commit	e2ffecb
🔍 Latest deploy log	https://app.netlify.com/sites/bulletproof-react-app/deploys/66b8840be3de590008203180
😎 Deploy Preview	https://deploy-preview-193--bulletproof-react-app.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alan2207]

Hey @Zac-Evans , thanks for addressing these issues. I made some changes in order to keep the loaders colocated, for better maintainability.

[Zac-Evans]

@alan2207 Cool that makes sense, thanks for taking a look. In my personal project, the element was loading before the data was fetched when I dynamically imported the loaders. Very possible that's just an issue in my project, might be worth checking though.