test: change state tests to use HA constants

tests/test_binary_sensor.py

@@ -4,7 +4,7 @@
     DOMAIN as BINARY_SENSOR_DOMAIN,
     BinarySensorDeviceClass,
 )
-from homeassistant.const import ATTR_DEVICE_CLASS
+from homeassistant.const import ATTR_DEVICE_CLASS, STATE_ON, STATE_OFF
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers import entity_registry as er
 
@@ -41,7 +41,7 @@ async def test_parking_brake(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.my_model_s_parking_brake")
-    assert state.state == "on"
+    assert state.state == STATE_ON
 
     assert state.attributes.get(ATTR_DEVICE_CLASS) is None
 
@@ -51,7 +51,7 @@ async def test_charger_connection(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.my_model_s_charger")
-    assert state.state == "on"
+    assert state.state == STATE_ON
 
     # Not sure why this one is failing - checking device class works with other tests
     # assert state.attributes.get(ATTR_DEVICE_CLASS) is BinarySensorDeviceClass.PLUG
@@ -82,7 +82,7 @@ async def test_charging(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.my_model_s_charging")
-    assert state.state == "on"
+    assert state.state == STATE_ON
 
     assert (
         state.attributes.get(ATTR_DEVICE_CLASS)
@@ -95,7 +95,7 @@ async def test_car_online(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.my_model_s_online")
-    assert state.state == "on"
+    assert state.state == STATE_ON
 
     assert (
         state.attributes.get(ATTR_DEVICE_CLASS) == BinarySensorDeviceClass.CONNECTIVITY
@@ -113,15 +113,15 @@ async def test_car_asleep(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.my_model_s_asleep")
-    assert state.state == "off"
+    assert state.state == STATE_OFF
 
 
 async def test_battery_charging(hass: HomeAssistant) -> None:
     """Tests energy site battery charging is getting the correct value."""
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.battery_home_battery_charging")
-    assert state.state == "off"
+    assert state.state == STATE_OFF
 
     assert (
         state.attributes.get(ATTR_DEVICE_CLASS)
@@ -134,6 +134,6 @@ async def test_grid_status(hass: HomeAssistant) -> None:
     await setup_platform(hass, BINARY_SENSOR_DOMAIN)
 
     state = hass.states.get("binary_sensor.battery_home_grid_status")
-    assert state.state == "on"
+    assert state.state == STATE_ON
 
     assert state.attributes.get(ATTR_DEVICE_CLASS) == BinarySensorDeviceClass.POWER

tests/test_climate.py

@@ -4,7 +4,7 @@
 from homeassistant.components.climate import (
     DOMAIN as CLIMATE_DOMAIN,
 )
-from homeassistant.const import ATTR_ENTITY_ID, ATTR_TEMPERATURE
+from homeassistant.const import ATTR_ENTITY_ID, ATTR_TEMPERATURE, STATE_OFF
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers import entity_registry as er
 
@@ -29,7 +29,7 @@ async def test_climate_properties(hass: HomeAssistant) -> None:
 
     state = hass.states.get(DEVICE_ID)
 
-    assert state.state == "off"
+    assert state.state == STATE_OFF
 
     assert (
         state.attributes.get("min_temp")

tests/test_update.py

@@ -4,7 +4,7 @@
 
 from homeassistant.components.update import DOMAIN as UPDATE_DOMAIN
 
-from homeassistant.const import ATTR_ENTITY_ID
+from homeassistant.const import ATTR_ENTITY_ID, STATE_OFF, STATE_ON
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers import entity_registry as er
@@ -34,7 +34,7 @@ async def test_status_download_wait_wifi(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "on"
+    assert state.state == STATE_ON
     assert state.attributes.get("latest_version") == "2022.36.20 (Waiting on Wi-Fi)"
     assert state.attributes.get("installed_version") == "2022.8.10.1"
     assert state.attributes.get("in_progress") is False
@@ -63,7 +63,7 @@ async def test_status_downloading(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "on"
+    assert state.state == STATE_ON
     assert state.attributes.get("latest_version") == "2022.36.20 (Downloading)"
     assert state.attributes.get("installed_version") == "2022.8.10.1"
     assert state.attributes.get("in_progress") is False
@@ -92,7 +92,7 @@ async def test_status_available(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "on"
+    assert state.state == STATE_ON
     assert state.attributes.get("latest_version") == "2022.36.20 (Available to install)"
     assert state.attributes.get("installed_version") == "2022.8.10.1"
     assert state.attributes.get("in_progress") is False
@@ -127,7 +127,7 @@ async def test_status_scheduled(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "on"
+    assert state.state == STATE_ON
     assert (
         state.attributes.get("latest_version") == "2022.36.20 (Scheduled for install)"
     )
@@ -162,7 +162,7 @@ async def test_status_installing(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "on"
+    assert state.state == STATE_ON
     assert state.attributes.get("latest_version") == "2022.36.20 (Installing)"
     assert state.attributes.get("installed_version") == "2022.8.10.1"
     assert state.attributes.get("in_progress") == 30
@@ -191,7 +191,7 @@ async def test_status_none(hass: HomeAssistant) -> None:
     await setup_platform(hass, UPDATE_DOMAIN)
 
     state = hass.states.get("update.my_model_s_software_update")
-    assert state.state == "off"
+    assert state.state == STATE_OFF
     assert state.attributes.get("latest_version") == "2022.8.10.1"
     assert state.attributes.get("installed_version") == "2022.8.10.1"
     assert state.attributes.get("in_progress") is False