Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heated Seats support via the Select entity #187

Closed
wants to merge 2 commits into from

Conversation

Megabytemb
Copy link
Contributor

Add Heated Seats support via the Select entity

Limitations:

  1. The Heated Seat data relies on the Climate Data from Tesla. This only returns a value while the climate is on. This means that the select entities will stay in their previous state until the climate is turned on in the car. The selects update as expected while Climate is turned on.
  2. Heated Seats will only change while climate is enabled. This means that if you want to turn on a heated seat, you need to first turn on the climate control, then change the select to the desired level. This is a limitation of the Tesla API.

I thought about automating turning on the climate if the user sets an option and climate isn't on, but automatically turning on the climate could have unintended consequences.

Heated Seats are off if climate control is off.
get seat heat level returns None if climate is off.
@alandtse
Copy link
Owner

I assume this is ready to integrate right?

@Megabytemb
Copy link
Contributor Author

Same issue as heated steats - need to make it match the app.

If you like, i can close this PR, and roll the changes into the seats PR as a more overall climate control update.

@alandtse
Copy link
Owner

No need to close it. I just noticed the commit message so thought you may have done it.

@Megabytemb
Copy link
Contributor Author

Closing this as the code has been rolled into the larger climate controls pr #188

@Megabytemb Megabytemb closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants