-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Heated Steering Wheel and Seats #188
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1c83a90
Add Support for Select and Heated Seats
Megabytemb fd1db45
Match Tesla Functionality.
Megabytemb 223e74f
Add Support for Heated Steering Wheel
Megabytemb 7942e5a
Wait for HVAC to turn on.
Megabytemb 4dd0668
Merge branch 'add-heated-seats' of github.com:megabytemb/tesla into H…
Megabytemb f0d3552
Sizeable refactor to snable shared climate states.
Megabytemb 8300989
tigher controls over climate Refresh hack
Megabytemb 7e23a21
Add Support for Select and Heated Seats
Megabytemb e8dbc3d
Match Tesla Functionality.
Megabytemb 1e9867d
Add Support for Heated Steering Wheel
Megabytemb c2324e7
Wait for HVAC to turn on.
Megabytemb 4a4bba6
Sizeable refactor to snable shared climate states.
Megabytemb bfd8cb5
tigher controls over climate Refresh hack
Megabytemb 98313e0
Merge branch 'Heated-Steering-Wheel' of github.com:megabytemb/tesla i…
Megabytemb c6124d2
remove unneeded library from testing
Megabytemb f300afd
add check_for_reauth to be consistent.
Megabytemb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it will repeatedly send the climate on command every second for up to 30s?
Wouldn't you rather send it once and wait? Or is it sometimes flaky, and the 30 retries be potentially useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is probably not the best way to implement because it will spam the api. Thinking about this more, it's probably much cleaner to have a single api command that sends the hvac start command, checks ever few seconds to see if it's been enabled, and then issues the second command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really feels like the wakeup decorator. Instead of waking up the car, it instead is enabling the hvac.