fix: Update tests for hass built-in unit conversions in 2022.11 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we need to update the ha custom component helper.... https://github.com/MatthewFlamm/pytest-homeassistant-custom-component |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating homeassistant brought about failures in existing tests due to hass automatically converting units in sensors from miles to km (and speed equivalents).
There doesn't seem to be a way to globally disable unit conversion for tests, so this PR fixes failing tests by converting the mock values if necessary. This feels like a hack, so I'm open to suggestions. I alternatively tried setting
hass.config.unitsto imperial, but that breaks the temperature tests since it converts the mock Celsius temps into Fahrenheit, so a conversion of the mock values would be needed regardless.