Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sch departure and charging binary sensor #441

Merged
merged 10 commits into from
Dec 20, 2022

Conversation

InTheDaylight14
Copy link
Contributor

No description provided.

@InTheDaylight14 InTheDaylight14 marked this pull request as ready for review December 19, 2022 20:19
@InTheDaylight14
Copy link
Contributor Author

#164 I don't think this fully closes the issue. We really need an input_time entity made available to integrations or the dedicated service calls.

@alandtse
Copy link
Owner

I'll merge this for now. We're limited by what HA exposes to us and I'm reluctant to try to hack other items like a text input to get that functionality.

@alandtse alandtse merged commit f555131 into alandtse:dev Dec 20, 2022
@InTheDaylight14
Copy link
Contributor Author

I think these binary sensors would still be helpful even if we had the full solution available. I'm on the fence with a number input being the "minutes after midnight". That's doesn't feel very intuitive.

@InTheDaylight14 InTheDaylight14 deleted the sch-binary branch December 21, 2022 15:42
@larstobi
Copy link

larstobi commented Jan 5, 2023

I think these binary sensors would still be helpful even if we had the full solution available. I'm on the fence with a number input being the "minutes after midnight". That's doesn't feel very intuitive.

@InTheDaylight14

In the Tesla app, we can only set the minutes in 15 minute increments.

If I add an Entity card with the input_datetime helper, using only time (not datetime) then I can set hour and minute. Perhaps this helper can be used to provide input to a charger input, and it just convert the hours+minutes to only minutes before sending it to the Tesla API?

@InTheDaylight14
Copy link
Contributor Author

In the Tesla app, we can only set the minutes in 15 minute increments.

Huh, I did not know this. Guess I have never tired to set it to odd minutes in the hour.

If I add an Entity card with the input_datetime helper, using only time (not datetime) then I can set hour and minute. Perhaps this helper can be used to provide input to a charger input, and it just convert the hours+minutes to only minutes before sending it to the Tesla API?

HA integrations cannot make an input_datetime automatically. That entity type can only be added by individual users. My recommendation here is to use templates to convert an input_datetime into the equivalent minutes after midnight the API expects to receive. Then use that template in the custom_api call found in the Wiki here.

If and when integrations can add a Time entity I'd like to build out switches for scheduling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants