Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump teslajsonpy to fix charge current #484

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jan 15, 2023

A fix to the set charge current function was made in the upstream library, and so a bump is required to fix #479

@Bre77 Bre77 changed the title Bump teslajsonpy to fix charge current Fix: Bump teslajsonpy to fix charge current Jan 15, 2023
@Bre77 Bre77 changed the title Fix: Bump teslajsonpy to fix charge current fix: Bump teslajsonpy to fix charge current Jan 15, 2023
@alandtse
Copy link
Owner

alandtse commented Jan 15, 2023

No need to edit the changelog as that is handled by semantic release. Please bump project.toml and update poetry.

Edit: nevermind on changelog. Just noticed it was precommit

@alandtse
Copy link
Owner

alandtse commented Jan 17, 2023

Did you manually edit poetry.lock? You need to run poetry lock or poetry update. There's a hash it updates to be consistent.

@Bre77
Copy link
Contributor Author

Bre77 commented Jan 17, 2023

I'm unfamiliar with poetry and it's throwing lots of errors and trying to change multiple package versions on my Windows machine. I think I convinced it to just update the lock file content hash now.

If this still isn't correct, I'd suggest rejecting this PR and bumping using your existing development environment.

@alandtse alandtse merged commit fa4bb7e into alandtse:dev Feb 1, 2023
@Bre77 Bre77 deleted the patch-1 branch February 3, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successful service calls are not optimistic
2 participants