refactor: reduce code needed to construct entities #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Just to confirm, you've marked this as fix. But does it actually solve a bug or issue? Or was it just to clean up code. |
|
Its just code cleanup. Intent was to generate a release |
|
I think our ci settings only generate a release on feat or bug. I'll see if I can tweak it for perf and refactor too. Didn't you solve a wake issue? Pulling in the new dependency may count as a fix. |
bdraco
changed the title
https://pypi.org/project/teslajsonpy/ It looks like the publish failed |
|
Thanks. Fixed the pypi publish. 3.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.