Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update manifest.json - bumped teslajsonpy version to latest #833

Closed
wants to merge 1 commit into from

Conversation

mcc05
Copy link

@mcc05 mcc05 commented Jan 26, 2024

bumped teslajsonpy version to latest, to fix powerwall control issues #832 for next pending release 3.19.6

bumped teslajsonpy version to latest, to fix powerwall control issues alandtse#832 for next pending release 3.19.6
@skipishere skipishere changed the title Update manifest.json - bumped teslajsonpy version to latest chore: Update manifest.json - bumped teslajsonpy version to latest Jan 26, 2024
@skipishere
Copy link
Collaborator

@alandtse think this is ready to merge if you're happy?

@skipishere skipishere added teslajsonpy Issue with dependency dependencies Pull requests that update a dependency file and removed teslajsonpy Issue with dependency labels Jan 26, 2024
@skipishere
Copy link
Collaborator

skipishere commented Jan 26, 2024

Looking at a previous PR to update teslajsonpy (49d1c22) it looks like you also need to update

@mcc05
Copy link
Author

mcc05 commented Jan 26, 2024

Ok done

@skipishere
Copy link
Collaborator

Looks like it might have been done on a different branch/pr. You'll want to do them all in the same PR. Also (this is all new to me as well) will need to update the poetry.lock file by running poetry update (from #772 (comment))

@mcc05
Copy link
Author

mcc05 commented Jan 26, 2024

Ok now I'm stuck, don't want to balls things up on poetry.lock TBH no idea what I'm doing with that not familiar with it at all :(

@alandtse
Copy link
Owner

It needs to be done with poetry update. It can't be manual.

@mcc05
Copy link
Author

mcc05 commented Jan 26, 2024

Ok @alandtse sorry I don't have this setup as a build environment, hence probably more of a hindrance than a help sorry!

@alandtse
Copy link
Owner

Ok, went ahead and did a formal bump

@alandtse alandtse closed this Jan 26, 2024
@alandtse
Copy link
Owner

Thanks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants