Add test for CLI tsconfig support #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps confirm that the code change from #822 is safe, which it seems to be. Previously, this code path was untested, but now that there are CLI integration tests, it's not so bad to write a new one for this case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 56 56
Lines 6082 6082
Branches 1446 1446
=======================================
Hits 5395 5395
Misses 421 421
Partials 266 266 ☔ View full report in Codecov by Sentry. |
Benchmark resultsBefore this PR: 563.2 thousand lines per second Measured change: 0.93% faster (1.01% slower to 1.67% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps confirm that the code change from #822 is safe, which it seems to be. Previously, this code path was untested, but now that there are CLI integration tests, it's not so bad to write a new one for this case.