[core] Use an immutable approach to overriding core functionality #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmcgovern
force-pushed
the
better-factories
branch
3 times, most recently
from
3e93877 to
94a644e
Compare
Require the user of the library to create the 'Factories' object before initializing the engine, and ensure 'Factories' is immutable. If someone wants to enable/disable something core, like proxy support, then it's far easier to do that safely/reliably if they also instantiate a new ClientEngine object. These are things which should not change for the lifetime of a torrent, unlike the more mutable EngineSettings or ClientSettings.
alanmcgovern
force-pushed
the
better-factories
branch
from
94a644e to
8feb114
Compare
Fold this into 'Factories'
Now we can make IncrementalCacheHash non-static and instantiate it using the SHA1Creator in the Factory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require the user of the library to create the 'Factories' object
before initializing the engine, and ensure 'Factories' is immutable.
If someone wants to enable/disable something core, like proxy support,
then it's far easier to do that safely/reliably if they also instantiate
a new ClientEngine object.
These are things which should not change for the lifetime of a torrent,
unlike the more mutable EngineSettings or ClientSettings.