[dht] Use SpeedMonitor to calculate DHT data rates #490
Conversation
Record total bytes sent/received, as well as the estimated transfer rate in bytes/second.
alanmcgovern
force-pushed
the
dht-transfer-stats
branch
from
fa88a98 to
c1130f1
Compare
|
This should give you the DHT stats you needed. Let me know what you think! |
| /// <summary> | ||
| /// Estimate of the amount of data sent every second, in bytes/second. | ||
| /// </summary> | ||
| long ReceiveRate { get; } | ||
|
|
||
| /// <summary> | ||
| /// Estimate of the amount of data sent every second, in bytes/second. | ||
| /// </summary> | ||
| long SendRate { get; } |
There was a problem hiding this comment.
I'm not sure how useful SendRate/ReceiveRate. If I grab the value every second, I want to know the average of the one second. Idk when I want to use the average of the 12 seconds (12 is hard-coded), so it's 'some average'. This value can be displayed only. It cannot be used for any kind of processing.
There was a problem hiding this comment.
In that case I suspect the best solution for you is to iterate over all active connections every N seconds, grab the total bytes sent/received and calculate the delta since the previous time your logic ran.
It would be very hard to provide anything else which isn't prone to skipping a value, or duplicating a value.
If the engine calculated the "average" over the last second, it would be hard to ensure you (the consumer of the library) always read the number exactly once per second.
Record total bytes sent/received, as well as the estimated transfer rate in bytes/second.