[core] Replace invalid characters in the generated path #493
Conversation
Replace invalid characters with the hex equivalent (and hope there is no collision). Addresses #491
|
Hi Alan, Thanks for the fix. The torrent downloaded correctly, however, the " were replaced by the string 22. Not a huge problem by itself, but then I cannot locate the actual final torrent folder by doing
since torrent.Name doesn't reflect the "fixed" folder name and still contains the invalid characters. Maybe you should add a read only property for the final folder full path? You are very close though. Thanks again. |
|
You can find the full paths to all files by accessing the TorrentManager.Files list and checking the FullPath property. In the meantime, ill have a think about the best way to expose a "ContainingDirectory" property which represents the sanitized path! |
'SavePath' is the path the user provides. By default a multi-file torrent will create a sub-directory within the directory specified by 'SavePath', and all files will be stored there. For single file torrents, the file will be stored directly within 'SavePath'. Hopefully the docs make this distinction clear and unambiguous.
Firstly, ensure the constructed path doesn't contain invalid characters. Secondly, ensure that path traversal attempts based on 'Torrent.Name' are rejected the same way they are for traversal attempts for individual torrent files. Any torrent attempting traversal will not be loaded.
|
There's a new If you use the public APIs to move files to different locations then these properties will have no clear/accurate meaning. However I'll merge this, and release an updated nuget package, as it seems to solve your first issue, and your followup issue has been solved too! Do let me know if you have any further issues/questions! |
Replace invalid characters with the hex equivalent (and hope
there is no collision).
Addresses #491