[core] Allow to load FastResume objects from a stream #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since FastResume.Encode() can write to a stream, it makes sense to allow FastResume.TryLoad() to load from a stream. This allows a client application to manage collections of FastResume objects.
|
Just in case you didn't know: You don't need to save fast resume data for individual torrents - you can save/restore the entire ClientEngine! This is a single method invocation and saves/restores EngineSettings, TorrentSettings, FastResume, if you've moved any TorrentFiles to non-default locations that is saved/restored too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
FastResume.Encode()can write to a stream, it makes sense to allowFastResume.TryLoad()to read from a stream. This allows a client application to manage collections ofFastResumeobjects.Right now there is no other way because all constructors are internal.