[core] Better read-only bitfield support #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having 'MutableBitfield' be a subclass of 'BitField' it's possible for users of the library to upcast to 'MutableBitField' and do the wrong thing. Follow the pattern of Memory<T>/ReadOnlyMemory<T> and create BitField and ReadOnlyBitField. BitField can be converted to 'ReadOnlyBitField' via an implicit cast, and you can create a BitField from a ReadOnlyBitField by using the appropriate constructor. This should make things a little bit clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having 'MutableBitfield' be a subclass of 'BitField' it's possible
for users of the library to upcast to 'MutableBitField' and do the wrong
thing.
Follow the pattern of Memory/ReadOnlyMemory and create BitField
and ReadOnlyBitField.
BitField can be converted to 'ReadOnlyBitField' via an implicit cast,
and you can create a BitField from a ReadOnlyBitField by using the
appropriate constructor.
This should make things a little bit clearer.