Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ReactExoplayerView): return unset track index when there are no t… #2

Merged
merged 1 commit into from
May 7, 2019

Conversation

rrosatti
Copy link
Collaborator

@rrosatti rrosatti commented May 6, 2019

…rack available

This fix was integrated on version 4.0.0. We need it in order to fix a problem
on Android, where the video freezes on the first frame when using a remote url
instead of an asset.

link to the upstream PR:
TheWidlarzGroup#1233

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:

Update the documentation

If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.

Update the changelog

After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

Provide an example of how to test the change

If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.

Focus the PR on only one area

Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.

Describe the changes

Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

@abnerf
Copy link

abnerf commented May 7, 2019

@rrosatti if this patch belongs to someone else and was already merged upstream, lets not recreate it here. Just cherry-pick the original commit into our repo. Would that work for you?

@rrosatti rrosatti force-pushed the fix-video-freezing-on-android branch from 24d05e6 to 2258b88 Compare May 7, 2019 16:27
@rrosatti
Copy link
Collaborator Author

rrosatti commented May 7, 2019

@abnerf it worked just fine! Sorry for that. I should have done it before!

I've just updated the PR, cherry picking the commit from master.

@abnerf
Copy link

abnerf commented May 7, 2019

@rrosatti cool! Ship it!

@rrosatti rrosatti changed the base branch from fix/disablefocus to develop May 7, 2019 20:44
@rrosatti rrosatti merged commit 2258b88 into develop May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants