GHC 9.10 support #136
Merged
GHC 9.10 support #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Over 1000 test failures. But at least they run.
Adds the ones fully enclosed in LocatedA spans, initial scaffolding in place for preceding comments at the top level.
Time to deal with the vestigial comments, into the HsModule anns
Current state of testing
Counts {cases = 1116, tried = 1116, errors = 3, failures = 17}
Now
Counts {cases = 1115, tried = 1115, errors = 2, failures = 15}
We synthesise the location, so must do the comment location comparison
by row,col only the RealSrcLoc Ord instance compares filenames too.
Counts {cases = 1115, tried = 1115, errors = 2, failures = 13}
Down to 7 failures
As they will be discarded when we exact print
Now zero failure, running all bar the makeDelta tests
Down to 473 failures
234 failures
175 failures
Needs a GHC patch, MR coming 161 failures
With appropriate change in GHC, MR coming
24 failing makeDeltaAst tests
We cannot sort comments when they have an EpaDelta location. But in the first pass (normal printing) we convert them to comments, which can have EpaDelta and are captured in the right place. So only sort if they do not have EpaDelta, and it works for both passes. Failures: roundtrip: 3 makeDeltaAst: 18
So it properly preserves the header comments distinct from the first decl But makeDeltaAst is failing, not sure why. If I disable insertCppComments it still fails
It causes too many warnings
So all tests pass bar the makeDeltaAst ones
For after we have reworked the top level comments to only attach immediately-preceding ones to a decl
https://gitlab.haskell.org/ghc/ghc/-/commits/wip/az/ghc-9.10-backports-1 In needs cabal from the ghc tree to build.
When https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12556 and https://gitlab.haskell.org/ghc/ghc/-/merge_requests/12557 land, and all are backported, GHC 9.10.1 should be good to go. Last few failures (in ghc910 test dir) are internal to ghc-exactprint itself, which needs minor tweaks.
Last few should be sortable in ghc-exactprint, all relate to comments which do appear in the AST we get.
Successful
All looking good so far
Hopefully
We now have pre-ghc910, and ghc-910.
We had a Bool parameter that was always provided as True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.