-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of genres. #266
base: master
Are you sure you want to change the base?
Conversation
Currently they don't seem to get returned. Signed-off-by: Aidan Epstein <aidan@jmad.org>
This requires this PR: alastair/python-musicbrainzngs#266
This requires this PR: alastair/python-musicbrainzngs#266
What needs to happen to merge and release this PR? It does appear that genre support does not work without this fix. |
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Thanks for the start on this work! I made a small change to also include the genre id attribute |
Great, thanks for maintaining this! Anything else I'd need to do for it to be merged? |
Any update to this one? |
@aereaux @alastair can one of you please fix ASAP? my grandfather just lost several evenings worth of manual tagging due to this issue and some tools that rely on these bindings. i'm restoring from a backup from last monday, but that's still 18-20 hours of lost work. please fix this, get the fix merged, and release a new version asap. this is causing data loss. |
Is there a release planned for this? It would be very nice have. |
Any chance of this PR being merged soon? It's coming up on 2 years old. |
here is a patched PKGBUILD with this for those who are on arch, quick solution until this will get merged |
Is this going to make the next release of beets? As it stands, there a no very reliable options for adding genres in beets. |
It would need to be merged and a new tag created. |
Hi @alastair, can you merge this? We're only a few months away from this being 2 years old. |
this issue is 3 years old |
Currently they don't seem to get returned.
This was taken from #247
Signed-off-by: Aidan Epstein aidan@jmad.org