Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/public key hash #157

Merged
merged 6 commits into from
May 22, 2024
Merged

Feature/public key hash #157

merged 6 commits into from
May 22, 2024

Conversation

rober12
Copy link
Contributor

@rober12 rober12 commented May 21, 2024

  • Updated the examples of the identity creation functions to use the new ones that works with the hash of the public key.
  • Updated the examples of the public Key functions to use the new ones that works with the hash of the public key.
  • Updated ci.yml to remove the step of executing the examples, since there is now no test blockchain node available and update the node version.

@rober12 rober12 requested a review from DaniRumpi May 21, 2024 16:21
DaniRumpi
DaniRumpi requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@DaniRumpi DaniRumpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay dos console.log que creo que sobran, míralos a ver que te parece.

@DaniRumpi DaniRumpi merged commit ea80ef1 into develop May 22, 2024
1 check passed
@DaniRumpi DaniRumpi deleted the feature/public-key-hash branch May 22, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniRumpi DaniRumpi DaniRumpi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rober12 @DaniRumpi