Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-libxslt fails to build with iojs 3.3.0 #24

Closed
tuananh opened this issue Sep 7, 2015 · 12 comments
Closed

node-libxslt fails to build with iojs 3.3.0 #24

tuananh opened this issue Sep 7, 2015 · 12 comments

Comments

@tuananh
Copy link

tuananh commented Sep 7, 2015

node-libxslt fails to build with iojs 3.3.0 with a bunch of error messages like:

error: assigning to 'v8::Function *volatile' from incompatible type 'v8::Value 

It seem sto related to nan.

@albanm
Copy link
Owner

albanm commented Sep 7, 2015

Yes, hopefully switching to nan 2 will solve this, cf #23

Migration is not trivial though, and not in my immediate plans. As usual a pull request would be welcome !

@benoror
Copy link

benoror commented Sep 8, 2015

@tuananh Maybe you want to try now that Node v4.0.0 (Stable) it's been announced, although probably resulting in the same kind of error.

I personally get the following error:

/home/bitnami/.node-gyp/4.0.0/include/node/node_buffer.h:43:40: note:   no known conversion for argument 2 from ‘const char*’ to ‘char*’
In file included from ../src/libxmljs.h:7:0,
                 from ../src/libxmljs.cc:7:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanNewBufferHandle(uint32_t)’:
../node_modules/nan/nan.h:676:61: error: could not convert ‘node::Buffer::New(v8::Isolate::GetCurrent(), ((size_t)size))’ from ‘v8::MaybeLocal<v8::Object>’ to ‘v8::Local<v8::Object>’
     return node::Buffer::New(v8::Isolate::GetCurrent(), size);
                                                             ^
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanBufferUse(char*, uint32_t)’:
../node_modules/nan/nan.h:683:12: error: ‘Use’ is not a member of ‘node::Buffer’
     return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);

Please refer to the complete error trace

@tuananh
Copy link
Author

tuananh commented Sep 9, 2015

Thanks. I settled with another lib for now. Will revisit this later

Tuan Anh Tran

On Wed, Sep 9, 2015 at 6:39 AM, Benjamin Orozco notifications@github.com
wrote:

@tuananh Maybe you want to try now that Node v4.0.0 (Stable) it's been announced, although probably resulting in the same kind of error.
I personally get the following error:

/home/bitnami/.node-gyp/4.0.0/include/node/node_buffer.h:43:40: note:   no known conversion for argument 2 from ‘const char*’ to ‘char*’
In file included from ../src/libxmljs.h:7:0,
                 from ../src/libxmljs.cc:7:
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanNewBufferHandle(uint32_t)’:
../node_modules/nan/nan.h:676:61: error: could not convert ‘node::Buffer::New(v8::Isolate::GetCurrent(), ((size_t)size))’ from ‘v8::MaybeLocal<v8::Object>’ to ‘v8::Local<v8::Object>’
     return node::Buffer::New(v8::Isolate::GetCurrent(), size);
                                                             ^
../node_modules/nan/nan.h: In function ‘v8::Local<v8::Object> NanBufferUse(char*, uint32_t)’:
../node_modules/nan/nan.h:683:12: error: ‘Use’ is not a member of ‘node::Buffer’
     return node::Buffer::Use(v8::Isolate::GetCurrent(), data, size);

Please refer to the complete error trace

Reply to this email directly or view it on GitHub:
#24 (comment)

@benoror
Copy link

benoror commented Sep 9, 2015

Which one (just curious)?

@tuananh
Copy link
Author

tuananh commented Sep 9, 2015

@benoror i went with another route. I plan to use xslt to transform document but changed to jsonpath instead now.

@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@gagern
Copy link
Collaborator

gagern commented Nov 16, 2015

Is this fixed by #26?

@MartijnR
Copy link

I don't think it's fixed yet. I added the 4.0, 4.1 and iojs (3.3.1) to Travis using latest master. See results here:

https://travis-ci.org/MartijnR/node-libxslt

@sergeche
Copy link

I was able to successfully compile node-xslt on Travis from master (not from NPM since it contains outdated libxmljs-mt dependency; @albanm could you publish new version to NPM, please?).

https://travis-ci.org/sergeche/node-libxslt/builds/92247939

The problem is that new nan and Node.js requires more recent version of GCC compiler. So in Travis you should either create custom install script and update GCC or simply switch to Ubuntu Trusty beta image:

sudo: required
dist: trusty

@tuananh
Copy link
Author

tuananh commented Nov 20, 2015

Awesome ;)

Tuan Anh Tranw: https://tuananh.org | e: me@tuananh.org | t: +84 91 223 45 11

On Fri, Nov 20, 2015 at 7:47 PM, Sergey Chikuyonok
notifications@github.com wrote:

I was able to successfully compile node-xslt on Travis from master (not from NPM since it contains outdated libxmljs-mt dependency; @albanm could you publish new version to NPM, please?).
https://travis-ci.org/sergeche/node-libxslt/builds/92247939
The problem is that new nan and Node.js requires more recent version of GCC compiler. So in Travis you should either create custom install script and update GCC or simply switch to Ubuntu Trusty beta image:

sudo: required
dist: trusty

Reply to this email directly or view it on GitHub:
#24 (comment)

@MartijnR
Copy link

That's fantastic!

@albanm
Copy link
Owner

albanm commented Nov 20, 2015

@sergeche I just published version 0.6.0

@albanm albanm closed this as completed Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants