Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log entry sorting by time. #1057

Closed
anonymous555 opened this issue Oct 16, 2023 · 8 comments
Closed

Log entry sorting by time. #1057

anonymous555 opened this issue Oct 16, 2023 · 8 comments
Assignees
Labels
Milestone

Comments

@anonymous555
Copy link

Looks like log entries are sorted by day, not time. So if there are multiple flights in the same day, they can show up in the wrong time order.

@albar965 albar965 self-assigned this Oct 16, 2023
@albar965 albar965 added the bug label Oct 16, 2023
@albar965 albar965 added this to the Release 2.8.13 milestone Oct 16, 2023
@albar965
Copy link
Owner

Thanks. I'll check.

@albar965
Copy link
Owner

Sorry, cannot reproduce this:
grafik

@anonymous555
Copy link
Author

Here's a screenshot
image

The latest flight is from KAEX to KHDC, but you can see PAFA, an earlier flight, listed first

@albar965
Copy link
Owner

I cannot see the time in your screenshot.

Maybe it helps if you send me your logbook database per email. This is
C:\Users\YOURUSERNAME\AppData\Roaming\ABarthel\little_navmap_db\little_navmap_logbook.sqlite on Windows.

https://albar965.github.io/contact.html

Alex

@anonymous555
Copy link
Author

little_navmap_logbook.zip

Ok here's the log sql.

@albar965
Copy link
Owner

Thanks a lot for the file. Give me a few days to look into this.

@albar965
Copy link
Owner

albar965 commented Nov 8, 2023

Sorry, I cannot reproduce this. I changed all to English/US locale and checked a lot of flights which happened the same day and they are correctly sorted:
image

@albar965
Copy link
Owner

albar965 commented Nov 8, 2023

Disregard my post above.
Found the issue. Manually editing log entries strips off the time zone. 🙄

albar965 added a commit that referenced this issue Nov 8, 2023
This resulted in wrong order when sorting by time in logbook table.
Now storing local real time with timezone offset.
@albar965 albar965 closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants