Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boosted version #1925

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Boosted version #1925

merged 1 commit into from
Sep 13, 2024

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Sep 13, 2024

Summary by Sourcery

Update the version number to 1.4.15 and correct a typo in the GridElasticDeform class docstring. Remove commented-out code in the SafeRotate class.

Enhancements:

  • Correct the class docstring in GridElasticDeform to fix a typo in the word 'Albumentations'.

Chores:

  • Update the version number from 1.4.14 to 1.4.15.

Copy link
Contributor

sourcery-ai bot commented Sep 13, 2024

Reviewer's Guide by Sourcery

This pull request includes minor version update and small changes to documentation and class inheritance in the Albumentations library. The changes are minimal but touch on version control, documentation accuracy, and code structure.

File-Level Changes

Change Details Files
Update library version
  • Increment version number from 1.4.14 to 1.4.15
albumentations/_version.py
Fix typo in GridElasticDeform class docstring
  • Correct 'Albumentation' to 'Albumentations' in the class description
albumentations/augmentations/geometric/transforms.py
Modify SafeRotate class inheritance
  • Change SafeRotate class to inherit from Affine instead of DualTransform
  • Remove commented-out line for previous class definition
albumentations/augmentations/geometric/rotate.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you provide more context on the change from DualTransform to Affine for the SafeRotate class? What are the implications or benefits of this modification?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ternaus ternaus merged commit c0af803 into main Sep 13, 2024
17 checks passed
@ternaus ternaus deleted the boost_version branch September 13, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant