-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix make docs #2179
Fix make docs #2179
Conversation
Reviewer's Guide by SourceryThis PR improves the docstring parsing logic for deprecated transforms and updates the documentation with additional transforms. The main change is in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
=========================================
+ Coverage 0 89.72% +89.72%
=========================================
Files 0 47 +47
Lines 0 8434 +8434
=========================================
+ Hits 0 7567 +7567
- Misses 0 867 +867 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Fix the deprecation check logic in the 'is_deprecated' function and update the README to include missing transform documentation.
Bug Fixes:
Documentation: