Allow using bools for writeConcern #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
write-concern-inconsistencies
branch
from
ad71afb
to
6711979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146. While
MongoCollection::setWriteConcernexpects thewoption to be a string or integer, one can pass a boolean aswoption to insert and update commands. To avoid a BC break for people who might have been using this undocumented feature, the WriteConcernConverter will cast a bool to int, resulting in a valid writeConcern object. While this will cause a minor inconsistency inMongoCollection::setWriteConcern(which no longer throws an error in the adapter), avoiding the BC break has priority.